Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Feb 11, 2025

What do these changes do?

Service owners can patch the service icon.

This icon is shown on the service card and it also used to "guess" the icon that should be shown on the study/template cards.

PatchIcon

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Feb 11, 2025
@odeimaiz odeimaiz added this to the Singularity milestone Feb 11, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Feb 11, 2025
@odeimaiz odeimaiz changed the title ✨ [Frontend] patch service icon ✨ [Frontend] Patch service icon Feb 11, 2025
@odeimaiz odeimaiz marked this pull request as ready for review February 11, 2025 13:54
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 when it comes to icons, why not to provide a pre-selection of some icons to select from instead of adding a random url? You can also add the last as a "custom icon" option

@odeimaiz
Copy link
Member Author

💡 when it comes to icons, why not to provide a pre-selection of some icons to select from instead of adding a random url? You can also add the last as a "custom icon" option

What would you suggest as a pre-selection for service icons? What is the last custom icon?

@sonarqubecloud
Copy link

@pcrespov
Copy link
Member

pcrespov commented Feb 11, 2025

💡 when it comes to icons, why not to provide a pre-selection of some icons to select from instead of adding a random url? You can also add the last as a "custom icon" option

What would you suggest as a pre-selection for service icons? What is the last custom icon?

@odeimaiz
Copy link
Member Author

odeimaiz commented Feb 11, 2025

💡 when it comes to icons, why not to provide a pre-selection of some icons to select from instead of adding a random url? You can also add the last as a "custom icon" option

What would you suggest as a pre-selection for service icons? What is the last custom icon?

If there is no icon set, the fallback is the product icon...

@odeimaiz odeimaiz merged commit 89d6628 into ITISFoundation:master Feb 11, 2025
56 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
63 tasks
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants